----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kservice Description ------- Changes are mostly related to containers/iterators, but there are also few QString related optimizations note that i have made a switch from QLinkedList to just QList because it performs better for T=<void*> also i have changed QStringList to QSet<QString> in one place to make the code run faster Diffs ----- src/sycoca/kbuildmimetypefactory.cpp 340f76a src/sycoca/kbuildservicefactory.cpp a74f2e8 src/sycoca/kbuildsycoca.cpp e99e906 src/sycoca/kmimeassociations.cpp 9423b27 src/sycoca/ksycocadict.cpp f33d01a src/sycoca/ksycocafactory.cpp e410581 Diff: https://git.reviewboard.kde.org/r/127215/diff/ Testing ------- all tests pass, except kmimeassociationstest (fakeApplicationService is NULL), but it fails also without my changes Thanks, Nick Shaforostoff
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
