----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/#review91918 -----------------------------------------------------------
Looks correct, although IMHO it's the code that creates a class, that should decide how it should get deleted, rather than the class itself deciding that (same reason why for widgets, WA_DeleteOnClose should be set after new, not in the ctor). - David Faure On Feb. 1, 2016, 9:16 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126955/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 9:16 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 351485 > http://bugs.kde.org/show_bug.cgi?id=351485 > > > Repository: kactivities > > > Description > ------- > > Currently we call deleteLater() from inside ::run which is running in a > different thread than the receiving object. > (QThread objects live in the thread that created them, not in the thread they > create) > > This patch causes deleteLater to be run in the right thread. > > QCoreApplication::postEvent is thread safe but it needs to be in the right > thread to work out the correct event loop level for deferred delete events. > > BUG: 351485 > > > Diffs > ----- > > src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp > 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a > > Diff: https://git.reviewboard.kde.org/r/126955/diff/ > > > Testing > ------- > > Right click in dolpin. Still works. > > Couldn't reproduce the original crash, so I don't know for sure it fixes it. > Debug in qcoreapplication showed we got a different eventLoopLevel on the > QDeferredDeleteEvent > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
