----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/ -----------------------------------------------------------
Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, and Christoph Feck. Repository: kwidgetsaddons Description ------- Currently a KNewPasswordDialog makes use of a KTitleWidget to display messages to the user about the password status (e.g. "password too short", etc.). This looks out of place, and so does the associated icon (see screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ ) This patch replaces the KTitleWidget with a KMessageWidget. I also "downgraded" some of the previous "error" red icons to a `KMessageWidget::Warning` type (the orange one in the screenshots), because those kind of messages may be displayed before the user even started typing something as password. Diffs ----- src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f Diff: https://git.reviewboard.kde.org/r/126523/diff/ Testing ------- The KMessageWidgets behaves exactly like the KTitleWidget before: initially is hidden, then is displayed as soon as the user interacts with the password fields. File Attachments ---------------- pwd-dialog-1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png pwd-dialog-2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png pwd-dialog-3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png Thanks, Elvis Angelaccio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
