----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review89981 -----------------------------------------------------------
src/klocalizedstring.cpp (line 231) <https://git.reviewboard.kde.org/r/126476/#comment61673> Why is kls being passed here? The method is supposed to act on its own members. The second version is much better, since it does not change the behavior of the non-QML plural handling. It should be stated somewhere in documentation that when using plural calls in QML, the first argument must be the plural-deciding number. Best in the part where it currently mentions that the first integer-typed argument is plural-deciding. - Chusslove Illich On Дец. 23, 2015, 1:53 по п., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126476/ > ----------------------------------------------------------- > > (Updated Дец. 23, 2015, 1:53 по п.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Also considers double values to check for plurals. > > In QML it's hard to ensure a value is an integer and we'd get unreliable > results, e.g. `i18nd("%1 thing", "%1 things", 3-i)`. > > Also it creates a separate function to reuse some code. > > > Diffs > ----- > > autotests/ki18ndeclarativetest.cpp cf8e778 > autotests/test.qml 314b516 > src/klocalizedcontext.cpp 3bc42dd > src/klocalizedstring.cpp 69950d2 > > Diff: https://git.reviewboard.kde.org/r/126476/diff/ > > > Testing > ------- > > Added new tests, which now pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
