----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/ -----------------------------------------------------------
(Updated Dec. 23, 2015, 1:53 p.m.) Review request for KDE Frameworks and Chusslove Illich. Changes ------- Another approach. I've been digging through documentation, apparently using floating point for plural never makes sense: https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html Now what it does is to always take as integer the first argument in plural forms, which is what I'd expect to be happening on most cases. This leaves non-qml cases untouched (except for the code de-duplication that I'd appreciate if someone could +1 so I can commit separately). Repository: ki18n Description ------- Also considers double values to check for plurals. In QML it's hard to ensure a value is an integer and we'd get unreliable results, e.g. `i18nd("%1 thing", "%1 things", 3-i)`. Also it creates a separate function to reuse some code. Diffs (updated) ----- autotests/ki18ndeclarativetest.cpp cf8e778 autotests/test.qml 314b516 src/klocalizedcontext.cpp 3bc42dd src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing ------- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
