----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 -----------------------------------------------------------
I just realized another problem with this approach: since the latest libkonq release installs konqpopupmenuplugin.desktop already, this patch will make the next KIO release conflict with that last libkonq release (which by definition cannot have a version check). Moving stuff between products is hard! So you were right, better install this under a different filename like in your v1 of the patch (just doublecheck that having two definitions of the same servicetype in two different files doesn't break things, but I don't think it does). And in the second step (later) we can reuse that filename to provide a different servicetypename and deprecate KonqPopupMenuPlugin. Sorry for not realizing this sooner. In any case, due to the issue with translations we wanted to commit this after today's release (but of course this delays the fix by one month). Unless Luigi is available this weekend to do the merging, but it's getting tight. - David Faure On Oct. 3, 2015, 7:50 a.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 7:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > ------- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > ----- > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > ------- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
