> On Sept. 28, 2015, 7:30 vorm., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both.... and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right? Not only those that are installed by > applications and libraries that are hosted on git.kde.org (which we could at > least find and fix), but also service menus that are released on > kde-apps.org, or unreleased menus that users have written for themselves. I > thought that it's unrealistic that this happens for every single service > menu, that's why I thought that the KonqPopupMenu/Plugin type should be kept. > Or am I overlooking something? If not, then I'm happy to change the file name > - probably having a konqpopupmenuplugin.desktop in KIO is really less > confusing than the ServiceType/file name mismatch. > > David Faure wrote: > Yes this is why I was suggesting to install desktop files for both names. > Deprecating != removing. > > Make both servicetype names work, but issue a warning if a plugin only > implements KonqPopupMenu/Plugin and not KIOServiceMenuPlugin (both is ok, > it's a way to make it work for older versions of KF5). Only > KIOServiceMenuPlugin is ok of course. > > Anyway, that's more work, if you want to just rename the file and move on > I'm ok with that. > In any case, make sure to avoid the conflict between kio and libkonq > installing the same file, with a version check.
Thanks David for the clarification! Yes, that makes a lot of sense. Sorry for the misunderstanding - I did not realize that you meant "skipping the installation of konqpopupmenuplugin.desktop *in kde-baseapps* if the KIO version is > 5.15". I'll update the patch soon. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 ----------------------------------------------------------- On Sept. 27, 2015, 6:18 nachm., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 6:18 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > ------- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > ----- > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/kioservicemenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > ------- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
