----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/#review84914 -----------------------------------------------------------
It's not your fault, but I still don't like this code (with or without these changes). It makes no sense to me ;) What I can't figure out from reading it is: why would relativePathOrUrl ever return a URL in this code path? We're calling it with the topMostUrl as argument, so it should always return a relative path. Right? Unless of course the selected URLs don't have a common top most url, but I think this case is not handled and very very hard to come up with anyway (how would one multi-select a local file and a file over FTP? I guess that's not possible). So then assuming we're dealing with a local path, why are we putting that into a QUrl, to then later extract it again using url.toDisplayString(QUrl::PreferLocalFile)? Why not directly put the relative path into "stringlist"? Do you want to try something like that? http://www.davidfaure.fr/2015/filewidgets_untested.diff src/filewidgets/kfilewidget.cpp (line 900) <https://git.reviewboard.kde.org/r/125051/#comment58742> remove trailing space - David Faure On Sept. 4, 2015, 9:32 p.m., Jean-Baptiste Mardelle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125051/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 9:32 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350696 > https://bugs.kde.org/show_bug.cgi?id=350696 > > > Repository: kio > > > Description > ------- > > QUrl::toDisplayString removes password info by default. When using local > files with ":" inside, toDisplayString returns empty filename > > > Diffs > ----- > > src/filewidgets/kfilewidget.cpp dc3c1f4 > > Diff: https://git.reviewboard.kde.org/r/125051/diff/ > > > Testing > ------- > > Patch fixes issue #350696, tested on my system, but maybe there is a better > way to fix it ? > > > Thanks, > > Jean-Baptiste Mardelle > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
