> On Sept. 4, 2015, 8:59 p.m., David Faure wrote: > > path() is wrong for local files on Windows, it should be toLocalFile() > > instead. > > > > If the use of local paths should depend on the mode, like in your patch, > > then just use toLocalFile() instead of path(). > > If the use of local paths should depend on whether the URL is local or > > remote, use toDisplayString(QUrl::PreferLocalFile).
Thanks for the quick review. In fact, the bug was a 2 parts issue, first problem was a few lines above by creating local urls with QUrl(String). Updated patch attached. - Jean-Baptiste ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125051/#review84856 ----------------------------------------------------------- On Sept. 4, 2015, 9:32 p.m., Jean-Baptiste Mardelle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125051/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 9:32 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350696 > https://bugs.kde.org/show_bug.cgi?id=350696 > > > Repository: kio > > > Description > ------- > > QUrl::toDisplayString removes password info by default. When using local > files with ":" inside, toDisplayString returns empty filename > > > Diffs > ----- > > src/filewidgets/kfilewidget.cpp dc3c1f4 > > Diff: https://git.reviewboard.kde.org/r/125051/diff/ > > > Testing > ------- > > Patch fixes issue #350696, tested on my system, but maybe there is a better > way to fix it ? > > > Thanks, > > Jean-Baptiste Mardelle > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
