----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123654/#review80187 -----------------------------------------------------------
autotests/kdirsortfilterproxymodel_benchmark.cpp (line 2) <https://git.reviewboard.kde.org/r/123654/#comment55016> I think this line should be you and 2015. autotests/kdirsortfilterproxymodel_benchmark.cpp (line 20) <https://git.reviewboard.kde.org/r/123654/#comment55017> <QTest> src/core/kfileitem.cpp (line 1115) <https://git.reviewboard.kde.org/r/123654/#comment55018> For reference, this has been touched twice by David. 1. http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=f02db3fdf69fd582baa05e0c7bbcf948648618df 2. http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=dc76b579b10a0e16930c4c9d7a067c97315d0e54 It does seem that his second commit made the first one obsolete butnever got removed. That's just wishful thinking though.. Heprobably knows best :) src/filewidgets/kdirsortfilterproxymodel.cpp (lines 46 - 51) <https://git.reviewboard.kde.org/r/123654/#comment55019> I don't see a reason for this, i probably miss something. The line where this was used (in the compare function) could just remain "m_collator.setCaseSensitivity(caseSensitivity);" right? src/filewidgets/kdirsortfilterproxymodel.cpp (line 83) <https://git.reviewboard.kde.org/r/123654/#comment55020> Why change this? The changes in KDirSortFilterProxyModel seem unrelated to the performance improvements in KFileItem. I think it would be best to split them in two seperate RR's. - Mark Gaiser On mei 6, 2015, 2:35 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123654/ > ----------------------------------------------------------- > > (Updated mei 6, 2015, 2:35 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Reduces some operations in KDirSortFilterProxyModel. > Removes usage of QUrl::fileName() in KFileItem::isHidden(), it comprised 75% > of the time spent running the benchmark in here. > > > Diffs > ----- > > autotests/CMakeLists.txt 010074d > autotests/kdirsortfilterproxymodel_benchmark.cpp PRE-CREATION > src/core/kfileitem.cpp 344ac67 > src/filewidgets/kdirsortfilterproxymodel.cpp 22ac025 > > Diff: https://git.reviewboard.kde.org/r/123654/diff/ > > > Testing > ------- > > Everything seems to be working still, including tests. > > There was a comment about trash:/ triggering an assert, but I couldn't > reproduce. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
