----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123654/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kio Description ------- Reduces some operations in KDirSortFilterProxyModel. Removes usage of QUrl::fileName() in KFileItem::isHidden(), it comprised 75% of the time spent running the benchmark in here. Diffs ----- autotests/CMakeLists.txt 010074d autotests/kdirsortfilterproxymodel_benchmark.cpp PRE-CREATION src/core/kfileitem.cpp 344ac67 src/filewidgets/kdirsortfilterproxymodel.cpp 22ac025 Diff: https://git.reviewboard.kde.org/r/123654/diff/ Testing ------- Everything seems to be working still, including tests. There was a comment about trash:/ triggering an assert, but I couldn't reproduce. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
