> On April 28, 2015, 8:26 p.m., Hrvoje Senjan wrote: > > As this breaks released KTp (15.04.x), IMHO best is either to revert this > > one, or still provide fallback for kservice plugins... > > I know KF5 guarantees binary and source compatibility, not explicitly > > runtime, but this will upset users and distros if they'll have broken > > contacts for 2 months until 15.08 get out...
You are correct. I didn't look at it this way. Instead of reverting, let me come up with a patch later on to solve this. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/#review79641 ----------------------------------------------------------- On April 20, 2015, 7:50 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123402/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 7:50 p.m.) > > > Review request for KDE Frameworks, KDEPIM and Martin Klapetek. > > > Repository: kpeople > > > Description > ------- > > Using KPluginFactory for instantiating the plugins, maybe we could do a bit > better there and just use QPluginLoader which is what we seem to need on most > cases. See discussion on depending patch. > > Tier 3 -> Tier 2 > > > Diffs > ----- > > CMakeLists.txt 11e2aa6 > metainfo.yaml 9795646 > src/CMakeLists.txt 225cee5 > src/personpluginmanager.cpp 9dd3f6e > src/widgets/actions.cpp ed7e02c > src/widgets/persondetailsview.cpp 8a2ef5c > > Diff: https://git.reviewboard.kde.org/r/123402/diff/ > > > Testing > ------- > > My KTP contact list still works, tests still pass and example applications > still work as well. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
