----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/ -----------------------------------------------------------
Review request for KDE Frameworks, KDEPIM and Martin Klapetek. Repository: kpeople Description ------- Using KPluginFactory for instantiating the plugins, maybe we could do a bit better there and just use QPluginLoader which is what we seem to need on most cases. See discussion on depending patch. Tier 3 -> Tier 2 Diffs ----- CMakeLists.txt 11e2aa6 metainfo.yaml 9795646 src/CMakeLists.txt 225cee5 src/personpluginmanager.cpp 9dd3f6e src/widgets/actions.cpp ed7e02c src/widgets/persondetailsview.cpp 8a2ef5c Diff: https://git.reviewboard.kde.org/r/123402/diff/ Testing ------- My KTP contact list still works, tests still pass and example applications still work as well. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
