> On March 21, 2015, 12:55 p.m., David Faure wrote: > > Yep (looks like you posted a followup commit rather than merging the two, > > and the commit log on reviewboard is outdated, it still talks about V3). > > But if you make sure to review and clean up the commit, you can commit.
I updated the diff from website. I will only commit the current diff, not multiple commits. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77880 ----------------------------------------------------------- On March 21, 2015, 1:07 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122970/ > ----------------------------------------------------------- > > (Updated March 21, 2015, 1:07 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kjobwidgets > > > Description > ------- > > Reuse org.kde.JobView.xml file that is no longer used anywhere. It now > contains the current org.kde.JobViewV2 interface spec. > org.kde.JobViewV2.xml is still available, but only for backwards > compatibility. > > This fixes source compatibility from 812d0b440e7f08e3acdd1c9bb95779bd871b75b3 > > > Diffs > ----- > > src/CMakeLists.txt c539bdc > src/kuiserverjobtracker.cpp 7f13a4d > src/kuiserverjobtracker_p.h daf3902 > src/org.kde.JobView.xml f64d232 > src/org.kde.JobViewV2.xml 245a5f0 > > Diff: https://git.reviewboard.kde.org/r/122970/diff/ > > > Testing > ------- > > plasma-workspace stable now builds fine > changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError > method. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
