----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77675 -----------------------------------------------------------
src/org.kde.JobViewV3.xml <https://git.reviewboard.kde.org/r/122970/#comment53324> don't you mean V3? Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger "not implemented" compilation error in the server. Kills extensibility. But not really a choice here, the client-side being in a framework. Maybe this is one case where the server should have its own copy of the xml file, instead of using the one from the framework. Duplication, but this V2 / V3 thing is duplication is well, and actually more complex to maintain. This change is still necessary for the existing plasma 5.2 to compile, but I would also change plasma in master to use its own copy of the xml file, so that the two xml files can be "upgraded" at different times, and without the need to define a new interface every time. - David Faure On March 18, 2015, 11:09 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122970/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 11:09 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kjobwidgets > > > Description > ------- > > This fixes source compatibility from https://git.reviewboard.kde.org/r/122926/ > > It adds a new org.kde.JobViewV3.xml file. The DBus interface name is still > JobViewV2 to keep compatibility with apps still using org.kde.JobViewV2.xml. > It also removes generating code from old org.kde.JobView.xml as it is not > used anywhere. > > > Diffs > ----- > > src/CMakeLists.txt c539bdc > src/kuiserverjobtracker.cpp 7f13a4d > src/kuiserverjobtracker_p.h daf3902 > src/org.kde.JobViewV2.xml 245a5f0 > src/org.kde.JobViewV3.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122970/diff/ > > > Testing > ------- > > plasma-workspace stable now builds fine > changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError > method. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
