> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 159
> > <https://git.reviewboard.kde.org/r/122413/diff/1/?file=346713#file346713line159>
> >
> > only emit if we've actually changed, otherwise every binding is going
> > to be recalculated every frame.
something like
if (rect.height() != m_paintedHeight) {
emit ...
}
?
> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h, line 34
> > <https://git.reviewboard.kde.org/r/122413/diff/1/?file=346712#file346712line34>
> >
> > if it goes here it should go on qimageitem too
> > should be a copy and paste.
I plan to do so in a separate commit once this is in.
- Luca
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/#review75332
-----------------------------------------------------------
On Feb. 3, 2015, 8:32 p.m., Luca Beltrame wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122413/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:32 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Like the corresponding properties in QML's Image, this patch introduces
> paintedWidth and paintedHeight to QPixmapItem, to get information on the size
> of the pixmap that's actually shown (depending on fillMode), as compared to
> its actual size.
>
> This brings QPixmapItem closer to the mode of usage of Image.
>
> CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem
>
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7
>
> Diff: https://git.reviewboard.kde.org/r/122413/diff/
>
>
> Testing
> -------
>
> Builds.
>
>
> Thanks,
>
> Luca Beltrame
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
