-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/#review75332
-----------------------------------------------------------



src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h
<https://git.reviewboard.kde.org/r/122413/#comment52105>

    if it goes here it should go on qimageitem too
    should be a copy and paste.



src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp
<https://git.reviewboard.kde.org/r/122413/#comment52106>

    only emit if we've actually changed, otherwise every binding is going to be 
recalculated every frame.


- David Edmundson


On Feb. 3, 2015, 7:52 p.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122413/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 7:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Like the corresponding properties in QML's Image, this patch introduces 
> paintedWidth and paintedHeight to QPixmapItem, to get information on the size 
> of the pixmap that's actually shown (depending on fillMode), as compared to 
> its actual size.
> 
> This brings QPixmapItem closer to the mode of usage of Image.
> 
> CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 
> 
> Diff: https://git.reviewboard.kde.org/r/122413/diff/
> 
> 
> Testing
> -------
> 
> Builds. 
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to