> On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: > > I'm not against this, but I am curious as to why this is being done. > > > > I would think that packagers should be building the tests and running them > > on their platform and make sure everything passes. We have a strict policy > > that all tests must always pass. > > Matthew Dawson wrote: > This is mostly useful on source based distributions (specifically, this > patch comes from Gentoo). While in general running tests everywhere would be > great, source distro users may not have the cpu time to compile/run tests. > Also, some test suites don't work and users may not care to figure out why > (for instance, last time I tried enabling tests in Gentoo, binutils failed > its suite). > > For binary distriubtions, I agree they should be running tests > (especially since we work to keep them green). But source based distros > aren't so clear cut. > > Andreas Sturmlechner wrote: > Exactly, packagers do build the tests of course, but that does not mean > users of source packages should have a permanent dependency on Qt5Test. > > Vishesh Handa wrote: > It is even more important for source based distros to be running tests. > They generally have very different compile options and flags. What is the > point of them running the software and possibly finding bugs, when it could > have been caught by just running the tests. > > Actually, the more I think about this, the more I realize that everyone > should be running the autotests. -2 from my side. But I'm not the maintainer > of kio.
> Exactly, packagers do build the tests of course, but that does not mean users > of source packages should have a permanent dependency on Qt5Test. On a source based distribution you already have a dependnecy on cmake, the compiler, and many other things. These are only required during build time. Qt5Test is the same. Once the pacakge has been built + tests have been run, Qt5Test can be removed. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review74602 ----------------------------------------------------------- On Jan. 22, 2015, 7:48 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122206/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 7:48 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > [kio] Make tests optional > This is a small patch to CMakeLists.txt to only depend on Qt5Test if > BUILD_TESTING. > > > Diffs > ----- > > CMakeLists.txt 7fe0be5d4b2d7d9475a7844b4f8d93fc2f0a00c3 > > Diff: https://git.reviewboard.kde.org/r/122206/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sturmlechner > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
