----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72634 -----------------------------------------------------------
low-level review: no need to create a QFile, use QFile::exists(path) higher-level review: ensuring that a file exists before calling KSaveFile, which *creates* the file, sounds weird. I mean, isn't this exactly what will happen the very first time a wallet is created? (disclaimer - I don't know this code so I'm probably missing context). - David Faure On Dec. 11, 2014, 2:16 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120388/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 2:16 a.m.) > > > Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin > Rusu. > > > Repository: kwallet > > > Description > ------- > > 1. Create a new wallet "foo" > 2. immediately remove the 'kwalletd5' directory > 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which > will create "foo.kwl") > > Kwalletmanager still lists the wallet and new data can be added to the > wallet, but this data will be lost once the wallet is closed since the salt > has been deleted and therefore the wallet cannot be opened again. > > > Diffs > ----- > > src/runtime/kwalletd/backend/kwalletbackend.cc b072cec > > Diff: https://git.reviewboard.kde.org/r/120388/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
