----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review67234 -----------------------------------------------------------
We already have old JSON and new JSON? Now I am indeed completely lost with this stuff. Seems application developers are, too, given the questions I got during Akademy. We (= the set of people who understand this stuff) need to write some porting documentation about this, in https://community.kde.org/Frameworks/Porting_Notes ... src/services/kplugininfo.h <https://git.reviewboard.kde.org/r/120198/#comment46914> 5.3 src/services/kplugininfo.cpp <https://git.reviewboard.kde.org/r/120198/#comment46915> unused - David Faure On Sept. 14, 2014, 2:05 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120198/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2014, 2:05 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > A series of 4 commits: > > ---- > > KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage > > This means that KPluginInfo can now simply reuse the QJsonObject > returned by QPluginLoader.metaData() (by storing it in a > KPluginMetaData object instead of having to convert the JSON to a > QVariantMap first. > > Additionally this allows very efficient conversion between KPluginInfo > and KPluginMetaData. > > --- > Add compatibility key names to KPluginInfo::property() > > --- > > KPluginInfo: Fix loading JSON metadata that only has compatibility keys > > This can be removed in KF6, but for now allows loading all both old > style as well as new style metadata > > ---- > > kplugininfotest: also test objects constructed from JSON > > This tests both new style JSON as well as JSON using the old key names > > > Diffs > ----- > > autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 > autotests/kplugininfotest.cpp 34f87028ce08f2db1e5f57edbc6f99a237bf90ac > src/services/kplugininfo.h dea07e6e63baf2483afc4a6d43d0892efc485903 > src/services/kplugininfo.cpp 50a6564edbbb1890c0b91badad69db967035231f > > Diff: https://git.reviewboard.kde.org/r/120198/diff/ > > > Testing > ------- > > All unit tests still work > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
