----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/#review69495 -----------------------------------------------------------
autotests/kplugininfotest.cpp <https://git.reviewboard.kde.org/r/120825/#comment48648> this comment doesn't match the expected result anymore.... src/services/kplugininfo.cpp <https://git.reviewboard.kde.org/r/120825/#comment48649> Just to make sure I understand -- entryPath will be like /full/path/to/plugin.so ? Isn't there a risk that some code will try to open it with a .desktop file parser? (e.g. KService). - David Faure On Oct. 29, 2014, 7:37 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120825/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 7:37 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kservice > > > Description > ------- > > Fix KPluginInfo::entryPath() being empty when not loaded from .desktop > > > Diffs > ----- > > autotests/kplugininfotest.cpp 34f87028ce08f2db1e5f57edbc6f99a237bf90ac > src/services/kplugininfo.cpp 50a6564edbbb1890c0b91badad69db967035231f > > Diff: https://git.reviewboard.kde.org/r/120825/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
