> On Oct. 21, 2014, 9:08 p.m., Alex Merry wrote: > > Ship It! > > Marko Käning wrote: > Hi Alex, did you test this successfully on Windows?
No, I'm expecting Luigi to interpret my shipit as approval of the CMake code in principle, and to exercise his own judgement in whether it's actually good to go. This is where the Gerrit +1/+2 system can be useful... - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 ----------------------------------------------------------- On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 12:12 a.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, > and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on > kdelibs4support. > > > Diffs > ----- > > cmake/uriencode.cmake PRE-CREATION > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
