> On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote: > > src/CMakeLists.txt, line 19 > > <https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19> > > > > You've already included it above... > > Luigi Toscano wrote: > This is different, it's in a piece of code inside install(CODE...) which > is executed in a different moment (installation time). From my quick test it > seems I need the previous include is in a different scope.
Ah, you're absolutely right. Sorry. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68696 ----------------------------------------------------------- On Oct. 20, 2014, 12:12 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 12:12 a.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, > and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on > kdelibs4support. > > > Diffs > ----- > > cmake/uriencode.cmake PRE-CREATION > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
