Nicolás Alvarez ha scritto: > 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez <nicolas.alva...@gmail.com>: >> 2014-09-09 12:22 GMT-03:00 David Faure <fa...@kde.org>: >>> On Sunday 17 August 2014 00:03:41 David Faure wrote: >>>> kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers >>>> API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, >>>> support for trash in FileUndoManager, and I'm about to add a >>>> KIO::restoreFromTrash job). >>>> And KIO::trash is called from the file dialog (kdiroperator.cpp). >>>> So this is a missing runtime dependency if kde-workspace/kio-extras isn't >>>> installed. >>>> >>>> How about we move kio_trash to the kio framework? >>>> >>>> (If we agree, can someone do it? I still have no experience with doing this >>>> in a way that preserves the git history) >>> >>> Aleix or Nicolas, can you move it? >> >> Done. The resulting history looks kind of weird though, because we >> have the full history of kio_trash but only partial history of kio, if >> you didn't graft kdelibs in. > > In fact, half the commits in kio are now from kio_trash. I didn't push > yet. I wonder if we should do the graft thing instead...
It was already done for kdoctools (where you can see two parents). I would say it makes sense to import just the post-split commits, as you are grafting kdelibs anyway for kio history. Ciao -- Luigi _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
