> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews. > > Hugo Pereira Da Costa wrote: > sorry. Will add > (being lazy) > > Ben Cooksley wrote: > You may wish to examine System Settings, it has very similar code as well > (If I recall correctly, the tooltip rendering code was copied between them - > and originally came from Dolphin).
Hi Ben, it appears systemsetting's tooltips painting was already fixed a while ago (just double checked) no artifact, stylePainter is already used there (and so is the case for dolphin) Btw: I wonder if this tooltip widget/manager would be a good candidate for kwidgetsaddons, so that applications would not have to duplicate the code (what you actually put in the tooltips contents being still the responsibility of the application) - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/#review65279 ----------------------------------------------------------- On Aug. 26, 2014, 2:43 p.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119940/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 2:43 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kinfocenter > > > Description > ------- > > as title says > the current custom code was made to match oxygen, and does not fit breeze any > more. > You end up with artifacts, incorrect rounding, wrong shadow etc. > also the current code is much simpler and works with all other themes too > > > Diffs > ----- > > ToolTips/ktooltipwindow.cpp 0ef540c > ToolTips/ktooltipwindow_p.h a9ac30f > > Diff: https://git.reviewboard.kde.org/r/119940/diff/ > > > Testing > ------- > > with oxygen, fusion, breeze > > > File Attachments > ---------------- > > kinfocenter-before.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/344a7dab-0dce-4a80-915b-8fccbd1b9f16__kinfocenter-before.png > kinfocenter-after.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/26/dc2d618e-077f-4f49-ba02-11420927a068__kinfocenter-after.png > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
