> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews.
sorry. Will add (being lazy) - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/#review65279 ----------------------------------------------------------- On Aug. 26, 2014, 2:14 p.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119940/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 2:14 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kinfocenter > > > Description > ------- > > as title says > the current custom code was made to match oxygen, and does not fit breeze any > more. > You end up with artifacts, incorrect rounding, wrong shadow etc. > also the current code is much simpler and works with all other themes too > > > Diffs > ----- > > ToolTips/ktooltipwindow.cpp 0ef540c > ToolTips/ktooltipwindow_p.h a9ac30f > > Diff: https://git.reviewboard.kde.org/r/119940/diff/ > > > Testing > ------- > > with oxygen, fusion, breeze > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
