----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65074 -----------------------------------------------------------
Is this going to lead to "make install" installing plugins into $QTDIR rather than into $CMAKE_INSTALL_PREFIX? This is a big no-no by default. For a developer, the path returned by qmake might not even be writable (/usr/...). QCA has an option to install into Qt, we could do the same here if you want, but it should be off by default. Distros can enable it when compiling packages for /usr. - David Faure On Aug. 22, 2014, 12:40 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119901/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 12:40 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Use qmake to query dirs for plugins and imports instead of hardcoding them in > ECM. > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 880539b > > Diff: https://git.reviewboard.kde.org/r/119901/diff/ > > > Testing > ------- > > Seems to work on my system. > > > Thanks, > > Rohan Garg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
