----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65037 -----------------------------------------------------------
Looks good. THere is a couple of things that is kind of a matter of "taste" and will let Alex comment on it: * should the qmake-query function be a secret underscore function * should the setting of the qmake_exe var happen inside the function or not - Sune Vuorela On Aug. 22, 2014, 12:40 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119901/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 12:40 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Use qmake to query dirs for plugins and imports instead of hardcoding them in > ECM. > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 880539b > > Diff: https://git.reviewboard.kde.org/r/119901/diff/ > > > Testing > ------- > > Seems to work on my system. > > > Thanks, > > Rohan Garg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
