> On Aug. 13, 2014, 7:47 a.m., David Faure wrote:
> > src/lib/io/kautosavefile.h, line 49
> > <https://git.reviewboard.kde.org/r/119530/diff/2/?file=303879#file303879line49>
> >
> >     To me kautosavefile was about the KOffice/Calligra use case: saving 
> > into a temp file in order to recover the stuff typed by the user and not 
> > saved yet, in case of a crash.
> >     
> >     For backups we also have KBackupFile, in kcoreaddons. This makes me a 
> > bit confused about who does what and what's the difference (between 
> > KBackupFile and KAutoSaveFile with this (new?) "backup" use case) for an 
> > app. Can you clarify?

You are correct.  It should serve one purpose well, answering this question: 
Did I crash while editing this file?  

At the time (4.8, 1 month ago), it could be used to answer these 3 questions:
Is there an autosave?
Did I crash?
Is someone else editing the file?

It did what I wanted, so I used it.


BTW, backupFile was hard to find in the documentation.  KBackup is a namespace 
that doesn't show up under the namespace list.  backupFile is non-member 
function of that namespace, so it has no place of its own in the documentation. 
 Neither show up in the search on http://api.kde.org . kbackup.h does show up 
in the filelist.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119530/#review64423
-----------------------------------------------------------


On Aug. 11, 2014, 9:22 p.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119530/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 9:22 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> kautosave doesn't work when any app tries to use a second filename, because 
> it doesn't filter on filename.  The unit tests can be droppped into master to 
> show the problem, if you remove the include on line 21.
> 
> This patch:
> 1. Adds unit tests to test more behavior mentioned in the header.
> 2. Fixes kautosave working with multple files per application.
> 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail 
> when the last 3 randomly generated characters in the filename matched any 3 
> consequtive chracters in the managed filename.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kautosavefile_p.cpp PRE-CREATION 
>   src/lib/io/kautosavefile_p.h PRE-CREATION 
>   src/lib/io/kautosavefile.cpp 13a13d7 
>   src/lib/io/kautosavefile.h 05cc3ae 
>   src/lib/CMakeLists.txt 26eb5a1 
>   autotests/kautosavefiletest.h cf70f4c 
>   autotests/kautosavefiletest.cpp ec0309e 
>   ! PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119530/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests.
> Ran kdeedu with kanagram.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to