----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/ -----------------------------------------------------------
Review request for KDE Frameworks and David Faure. Repository: kcoreaddons Description ------- kautosave doesn't work when any app tries to use a second filename, because it doesn't filter on filename. The unit tests can be droppped into master to show the problem, if you remove the include on line 21. This patch: 1. Adds unit tests to test more behavior mentioned in the header. 2. Fixes kautosave working with multple files per application. 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail when the last 3 randomly generated characters in the filename matched any 3 consequtive chracters in the managed filename. Diffs ----- src/lib/io/kautosavefile.cpp 13a13d7 src/lib/io/kautosavefileprivate.h PRE-CREATION src/lib/io/kautosavefileprivate.cpp PRE-CREATION autotests/kautosavefiletest.h cf70f4c autotests/kautosavefiletest.cpp ec0309e src/lib/CMakeLists.txt 26eb5a1 src/lib/io/kautosavefile.h 05cc3ae Diff: https://git.reviewboard.kde.org/r/119530/diff/ Testing ------- Ran unit tests. Ran kdeedu with kanagram. Thanks, Andreas Xavier
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
