kossebau added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:351
> +{
> + KBookmark bookmark = createSystemBookmark(manager, tag, tag,
> QUrl(QStringLiteral("tags:/") + tag), QStringLiteral("tag"));
> + bookmark.setMetaDataItem(QStringLiteral("tag"), tag);
@nicolasfella Hi. this is passing the tag string both as translation context as
well as the string to translate as well. Is this on purpose? Even more as the
context parameter is ignored anyway and just there to force a context for the
other cases being used with I18NC_NOOP values, to make sure a context is set at
all.
So where are those tag names coming from, are they expected to be translated at
all?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7700
To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham, broulik
Cc: kossebau, chehrlic, broulik, kde-frameworks-devel, bruns, rkflx, mmustac,
spoorun, michaelh, renatoo, anthonyfieroni, cfeck, elvisangelaccio, emmanuelp,
ngraham, alexeymin, #dolphin, sdorishlab, badbunny, waitquietly, azyx,
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, koehn, cblack,
fbampaloukas, alexde, Codezela, feverfew, meven, ahmadsamir, navarromorales,
firef, andrebarros, rdieter, mikesomov, vkrause
