> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > tests/CMakeLists.txt, lines 3-5 > > <https://git.reviewboard.kde.org/r/115863/diff/1/?file=244735#file244735line3> > > > > Not needed here, as far as I can see.
test_regression_fontoverload.cpp uses include <QX11Info> > On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote: > > CMakeLists.txt, lines 23-32 > > <https://git.reviewboard.kde.org/r/115863/diff/1/?file=244733#file244733line23> > > > > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never > > linked against. So there's not much point searching for them: we're > > already depending on them being bought in by other libraries. The listed frameworks are directly used. I don't see how linking or not makes a difference - khtml will fail to build without them. If we trust that one dependency will always bring in some other dependencies that we happen to also use, I am sure there are others we could remove too. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/#review50260 ----------------------------------------------------------- On Feb. 18, 2014, 8:01 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115863/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:01 a.m.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: khtml > > > Description > ------- > > - QtTest is only required for autotests > - QtX11Extras is only required for X11 builds, and for tests > - Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are > not used > > > Diffs > ----- > > CMakeLists.txt 3a3dbab90e6572cf953ba5edc1fcb60a7e30b493 > autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da > tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a > > Diff: https://git.reviewboard.kde.org/r/115863/diff/ > > > Testing > ------- > > Builds. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
