----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/#review50260 -----------------------------------------------------------
CMakeLists.txt <https://git.reviewboard.kde.org/r/115863/#comment35381> KCompletion, KConfig[Widgets] and KCoreAddons are used, but never linked against. So there's not much point searching for them: we're already depending on them being bought in by other libraries. CMakeLists.txt <https://git.reviewboard.kde.org/r/115863/#comment35382> Same goes for KJobWidgets CMakeLists.txt <https://git.reviewboard.kde.org/r/115863/#comment35383> And KService tests/CMakeLists.txt <https://git.reviewboard.kde.org/r/115863/#comment35379> Not needed here, as far as I can see. - Alex Merry On Feb. 18, 2014, 8:01 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115863/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:01 a.m.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: khtml > > > Description > ------- > > - QtTest is only required for autotests > - QtX11Extras is only required for X11 builds, and for tests > - Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are > not used > > > Diffs > ----- > > CMakeLists.txt 3a3dbab90e6572cf953ba5edc1fcb60a7e30b493 > autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da > tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a > > Diff: https://git.reviewboard.kde.org/r/115863/diff/ > > > Testing > ------- > > Builds. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
