dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ahmadsamir wrote in copyjob.cpp:477 > I meant connection to the remote ulr/host; however e.g Dolphin already > reports those connection errors in the status bar when it can't connect, so > the comment is redundant now... (I tried to keep the original code/comments > in tact, apparently that backfired spectacularly). I'm assuming the TODO was about "What if I'm using a NFS mount and the connection breaks at the time of KDiskFreeSpaceInfo, i.e. what should we do about error handling". But I think the current code -- which ignores errors and moves on, both for local and now for remote files, actually makes most sense. This is after all just a preliminary check. The worst that will happen is that there will indeed not be enough room and the copy will fail. But that's better than not trying at all, possibly due to a bug in one of those two classes, or possibly because of intermittent network failures. REPOSITORY R241 KIO BRANCH l-freespace-remote-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir, #frameworks, dfaure, meven, sitter Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
