ahmadsamir marked an inline comment as done. ahmadsamir added inline comments.
INLINE COMMENTS > dfaure wrote in copyjob.cpp:430 > This is the same as "actualDest" too, so its definition could be moved > further up and shared with this too. > > (Not that the name is perfect --- when copying ~/file.txt to ~/file2.txt, the > actual destination is ~/file2.txt. > Or copying ~/dir1 as ~/dir2, then the actual destination is ~/dir2. So even a > name like destDir isn't perfect...) > > existingDest maybe. ~ exists. ~/dir2 not yet. > This is the same as "actualDest" too, so its definition could be moved > further up and shared with this too. The code handling UDS_LOCAL_PATH is in between them, it may change m_dest. And "existingDest" it is. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir, #frameworks, dfaure, meven, sitter Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
