dfaure updated this revision to Diff 82058. dfaure added a comment.
-void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags runFlags) +void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b) The more I think about it, the least I like the use of flags here. 1. they are from the wrong class as Kai-Uwe pointed out, but more importantly: 2. the other bool setters here are for unrelated concerns, better keep them separate. Are we doing lineEdit->setDragEnabled(true); lineEdit->setClearButtonEnabled(true); lineEdit->setReadOnly(true); or are we doing lineEdit->setFlags(QLineEdit::DragEnabled | QLineEdit::ClearButtonEnabled | QLineEdit::ReadOnly)? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29385?vs=81840&id=82058 BRANCH 2020_05_openurljob REVISION DETAIL https://phabricator.kde.org/D29385 AFFECTED FILES autotests/CMakeLists.txt autotests/krununittest.cpp autotests/openurljobtest.cpp autotests/openurljobtest.h src/core/kurlauthorized.h src/gui/CMakeLists.txt src/gui/applicationlauncherjob.cpp src/gui/applicationlauncherjob.h src/gui/openurljob.cpp src/gui/openurljob.h src/gui/openurljobhandlerinterface.cpp src/gui/openurljobhandlerinterface.h src/widgets/CMakeLists.txt src/widgets/jobuidelegate.cpp src/widgets/kdesktopfileactions.cpp src/widgets/kopenwithdialog.cpp src/widgets/kopenwithdialog.h src/widgets/krun.cpp src/widgets/widgetsopenurljobhandler.cpp src/widgets/widgetsopenurljobhandler.h To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
