feverfew added a comment.
In D29385#662435 <https://phabricator.kde.org/D29385#662435>, @dfaure wrote: > In D29385#662422 <https://phabricator.kde.org/D29385#662422>, @feverfew wrote: > > > Quick question, how does this affect D23384 <https://phabricator.kde.org/D23384>? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of URLs to local KIOFuse URLs if needed, but now I believe this new API doesn't? > > > No worries, this should still happen. > KRun is actually split into three classes: OpenUrlJob, CommandLauncherJob and ApplicationLauncherJob. The last two delegate the work to an internal class, KProcessRunner (like KRun did). > So (to roll out the common case of a document-type file), once OpenUrlJob finds out which application to start, it calls ApplicationLauncherJob, which creates a KProcessRunner, which uses KIO::DesktopExecParser::resultingArguments(). Ahhh yes correct. Seeming as these jobs are now async (unlike KRun IIRC?), it isn't a problem that `resultingArguments` makes several blocking calls to the KIOFuse daemon? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
