kmaterka marked 2 inline comments as done. kmaterka added inline comments. INLINE COMMENTS
> cblack wrote in iconitem.cpp:58 > Is this class necessary? I feel like this class's behaviour should be what > its parent does without a child implementation. I wanted `IconItemStrategy` to be just an abstract base class, so that to have no strategy selected one needs to select null strategy explicitly. > cblack wrote in iconitem.cpp:80 > Seems unused. removed unused variable from NullStrategy REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns
