cochise updated this revision to Diff 77962.
cochise added a comment.
Tried to make a function to feed m_keyList on BSD, but the result was
somewhat ugly.
I don't like to use buffers if I can have typed data, but libc uses buffers,
so maybe I was putting the sqare piece on the circle hole.
So, accepted @bruns suggestion about the loop.
On a side note, I think the mac ifdef was never getting true, as
HAVE_SYS_XATTR should return true on mac, so changed from:
#if HAVE_SYS_XATTR_H && !defined(__stub_getxattr)
LINUX CODE
#elif defined(Q_OS_MAC)
MACOS CODE
to
#if HAVE_SYS_XATTR_H && !defined(__stub_getxattr) && !defined(Q_OS_MAC)
LINUX CODE
#elif defined(Q_OS_MAC)
MACOS CODE
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17816?vs=77955&id=77962
BRANCH
arcpatch-D17816_1
REVISION DETAIL
https://phabricator.kde.org/D17816
AFFECTED FILES
autotests/jobtest.cpp
autotests/jobtest.h
src/ioslaves/file/ConfigureChecks.cmake
src/ioslaves/file/file.h
src/ioslaves/file/file_unix.cpp
To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho,
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
