dfaure requested changes to this revision.
dfaure added inline comments.
INLINE COMMENTS
> cochise wrote in jobtest.cpp:573
> xtattr = MacOS command
> It uses a single command to read and write.
All of these are spelled with two consecutive 't'.
The code has a single 't' : getextatr.
> dfaure wrote in jobtest.cpp:638
> if (command.isEmpty())
> qWarning() << "ERROR: setfattr/setextattr/xattr not found";
>
> to make it easier to debug than just this method returning empty.
Was my comment ignored?
> dfaure wrote in jobtest.cpp:650
> QSKIP("This test requires setfattr")
>
> Otherwise it will look like a "PASS" in the test output.
My comment was ignored.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17816
To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho,
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
