ahmadsamir updated this revision to Diff 76705. ahmadsamir added a comment.
- Move the QRegularExpression definition out of the for loop, more efficient as it'll reused - match() always allocates a QRegularExpressionMatch anyway, so move it inside the while loop - Make the first () non-capturing since the capture group isn't needed REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26211?vs=72149&id=76705 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26211 AFFECTED FILES data/parsetrigrams.cpp To: ahmadsamir, cullmann, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns