cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
Actually, one can re-use this regex for all files by moving it before the scope of the loop, or? The match on the other side is allocated per match() call, I would just move that inside the inner stuff and just do some const auto match = rx.... REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26211 To: ahmadsamir, cullmann, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
