meven added a comment.
A few qDebug not to forget to clean before merging.
INLINE COMMENTS
> kio_smb_browse.cpp:380
>
> +
> udsentry.fastInsert( KIO::UDSEntry::UDS_NAME, udsName );
remove
> kio_smb_browse.cpp:544
> if (dir_is_root) {
> + qDebug() << "dir is root";
> udsentry.fastInsert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR);
qCDebug or remove
> kio_smb_browse.cpp:551
> {
> + qDebug() << "dir is not root";
> udsentry.fastInsert(KIO::UDSEntry::UDS_NAME, ".");
qCDebug or remove
> wsdiscoverer.cpp:88
> + {
> + qDebug() <<
> "===========================================================";
> + // NB: when windows talks to windows they use
> lms:LargeMetadataSupport we probably don't
Remove
> wsdiscoverer.cpp:116
> + if (response.isFault()) {
> + qDebug() << response.arguments();
> + qWarning() << response.faultAsString();
qCDebug or remove
qCWarning
> wsdiscoverer.cpp:152
> + if (hostInfo.error() == QHostInfo::NoError) {
> + qDebug() << "resolved hostName to " << hostInfo.hostName();
> + computer = hostInfo.hostName();
qCDebug or remove
> wsdiscoverer.cpp:155
> + } else {
> + qDebug() << "failed to resolve host for endpoint url:" <<
> m_endpointUrl;
> + }
qCDebug or remove
> wsdiscoverer.cpp:164
> +
> + qDebug() << "++++++++++++++++++++++++++++++++++++++++++++";
> + return new WSDiscovery(computer, m_endpointUrl.host());
remove
> wsdiscoverer.cpp:209
> +{
> + qDebug() << Q_FUNC_INFO;
> + m_probeMatchTimer.stop();
qCDebug or remove
> wsdiscoverer.cpp:224
> +{
> + qDebug() << "WSDISC match received
> -----------------------------------------";
> + // (re)start match timer to finish-early if at all possible.
qCDebug or remove
> wsdiscoverer.cpp:240
> +{
> + qDebug() << "resolveReceived -----------------------------------------";
> + // (re)start match timer to finish-early if at all possible.
qCDebug or remove
> wsdiscoverer.cpp:262
> + m_futures << QtConcurrent::run([=] {
> + qDebug() << "resolving discovery";
> + PBSDResolver resolver(addr, service->endpointReference());
qCDebug or remove
> wsdiscoverer.cpp:267
> + });
> + qDebug() << "WSDISC match received
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~";
> +}
qCDebug or remove
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D25682
To: sitter, dfaure, #frameworks, #dolphin
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson,
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun,
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
