sitter updated this revision to Diff 73405. sitter marked 19 inline comments as done. sitter added a comment.
since there's not been much design input let's move to actual review primary change here is that wsdiscoverer no longer uses qtconcurrent but instead signal slots on the same thread. ultimately discovery is blocking listDir, so the threading offerend very little advantage. I am not quite sure how to best implement the previous stop behavior where I'd wait on the qfuture. I've replaced it with a qapp::processevents, but I'm not sure that is the best approach. listDir itself still would benefit from a larger refactor to split it into its parts, that's not really impacting the change under review here though. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25682?vs=71121&id=73405 BRANCH arcpatch-D25682 REVISION DETAIL https://phabricator.kde.org/D25682 AFFECTED FILES smb/CMakeLists.txt smb/discovery.cpp smb/discovery.h smb/dnssddiscoverer.cpp smb/dnssddiscoverer.h smb/kdsoap-ws-discovery-client/.gitignore smb/kdsoap-ws-discovery-client/.gitlab-ci.yml smb/kdsoap-ws-discovery-client/CMakeLists.txt smb/kdsoap-ws-discovery-client/KDSoapWSDiscoveryClientConfig.cmake.in smb/kdsoap-ws-discovery-client/LICENSE smb/kdsoap-ws-discovery-client/README.md smb/kdsoap-ws-discovery-client/examples/CMakeLists.txt smb/kdsoap-ws-discovery-client/examples/onvif-discover/CMakeLists.txt smb/kdsoap-ws-discovery-client/examples/onvif-discover/main.cpp smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.cpp smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.h smb/kdsoap-ws-discovery-client/src/CMakeLists.txt smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.cpp smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.h smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.cpp smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.h smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.cpp smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.h smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-schema-os.xsd smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-wsdl-os.wsdl smb/kdsoap-ws-discovery-client/wsdl/download.sh smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/08/addressing smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.wsdl smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.xsd smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.wsdl smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.xsd smb/kdsoap-ws-discovery-client/wsdl/www.w3.org/2006/03/addressing/ws-addr.xsd smb/kio_smb.h smb/kio_smb_browse.cpp smb/wsdiscoverer.cpp smb/wsdiscoverer.h To: sitter, dfaure, #frameworks, #dolphin Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
