ilic added inline comments. INLINE COMMENTS
> dfaure wrote in kuitmarkup.cpp:90 > Interesting idea, this simplifies the code. > > However the name "wsRx" no longer matches what this regexp does. > > Also, the old trimming is missing here, isn't it? > I guess \s*:?\s* is needed, and \s*/?\s* > > Can you look into adding unittests for this stuff? Although I'm not sure if > that's possible. I recall I (or on someone's suggestion) didn't want to use regexes too much for performance reasons. In the original code, other than this whitespace regex, all other regexes appear in places where things went wrong and some heuristics was needed to reduce garbage in output. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26366 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
