> On Nov. 24, 2013, 9:20 p.m., Stephen Kelly wrote: > >
Nothing should need find_package(KDELibs4) at all anymore. Uses of it should be removed (or replaced with kde4support, if that's not already there), and then KDELibs4Config.cmake should be removed from kdelibs.git/frameworks. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114076/#review44353 ----------------------------------------------------------- On Nov. 24, 2013, 2:07 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114076/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2013, 2:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Set KDE4_INCLUDES in KDE4SupportConfig. > > This allows to compile kde-runtime without find_package(KDELibs4), > which seems otherwise redundant with find_package(KDE4Support). > > > Diffs > ----- > > tier4/kde4support/KDE4SupportConfig.cmake.in 1a8c9c4 > > Diff: http://git.reviewboard.kde.org/r/114076/diff/ > > > Testing > ------- > > kde-runtime compiles without find_package(KDELibs4) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
