----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114076/#review44353 -----------------------------------------------------------
tier4/kde4support/KDE4SupportConfig.cmake.in <http://git.reviewboard.kde.org/r/114076/#comment31718> This is the CMAKE_INSTALL_PREFIX of the caller, which is not necessarily the install prefix of upstream. tier4/kde4support/KDE4SupportConfig.cmake.in <http://git.reviewboard.kde.org/r/114076/#comment31719> Why is it necessary to set KDE4_INCLUDES at all? The correct include dirs should all come from the IMPORTED targets. What is the error encountered? - Stephen Kelly On Nov. 24, 2013, 2:07 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114076/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2013, 2:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Set KDE4_INCLUDES in KDE4SupportConfig. > > This allows to compile kde-runtime without find_package(KDELibs4), > which seems otherwise redundant with find_package(KDE4Support). > > > Diffs > ----- > > tier4/kde4support/KDE4SupportConfig.cmake.in 1a8c9c4 > > Diff: http://git.reviewboard.kde.org/r/114076/diff/ > > > Testing > ------- > > kde-runtime compiles without find_package(KDELibs4) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
