----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ -----------------------------------------------------------
(Updated Oct. 19, 2013, 11:30 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description ------- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs (updated) ----- kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing ------- Seems to work fine in a test app. Thanks, Teo Mrnjavac
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
