> On Oct. 19, 2013, 8:58 a.m., David Faure wrote: > > kio/kfile/kencodingfiledialog.h, line 128 > > <http://git.reviewboard.kde.org/r/113302/diff/1/?file=202321#file202321line128> > > > > If you export the class again, no need to export the static methods > > individually. > > > > Or was it intended to make the class private, even with this new > > solution? (in that case it should be documented, the ctor should be > > private, etc.)
Yes, the intention was to only export the static methods. I'll make the ctor private and document a bit. - Teo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/#review41957 ----------------------------------------------------------- On Oct. 17, 2013, 2:04 p.m., Teo Mrnjavac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113302/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 2:04 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Repository: kdelibs > > > Description > ------- > > This makes KEncodingFileDialog static, moves it to staging/kio and moves some > stuff from KFileDialog to KFileWidget to reduce duplication. > > > Diffs > ----- > > kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 > kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd > kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 > kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e > staging/kio/src/filewidgets/CMakeLists.txt > e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a > staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION > staging/kio/src/filewidgets/kfilewidget.h > f7b162ab39b997274b21f9eff0c6374545e0a9ad > staging/kio/src/filewidgets/kfilewidget.cpp > 824ac563f3f8c463426f0a45e792f107ac402a40 > > Diff: http://git.reviewboard.kde.org/r/113302/diff/ > > > Testing > ------- > > Seems to work fine in a test app. > > > Thanks, > > Teo Mrnjavac > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
