----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39244 -----------------------------------------------------------
find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28941> You could also wrap this in a XCB_FIND_QUIETLY condition. find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28943> Is it even possible to hit these fatal errors? I thought find_path and find_library would always set the variable to either the result or Foo-NOTFOUND ? find_path(XCB_wtf_INCLUDE_DIR NAMES xcb/wtf) if (NOT DEFINED XCB_wtf_INCLUDE_DIR) message("NOT DEFINED") endif() if (NOT XCB_wtf_INCLUDE_DIR) message("NOT TRUE: ${XCB_wtf_INCLUDE_DIR}") endif() return() prints NOT TRUE: XCB_wtf_INCLUDE_DIR-NOTFOUND as I expect... find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28944> This shouldn't be needed, because XCB_INCLUDE_DIRS and XCB_LIBRARIES are not cache variables at all, are they? If they are they probably shouldn't be. If you remove this line, do they show up in cmake-gui for example? find-modules/FindXCB.cmake <http://git.reviewboard.kde.org/r/112151/#comment28945> Are these for backward compatibility? XCB_INCLUDE_DIR and XCB_LIBRARY don't seem to be set before this patch. Did you instead mean to set backward compatibility variables for the component-specific variables? - Stephen Kelly On Sept. 3, 2013, 7:37 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112151/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 7:37 a.m.) > > > Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. > > > Description > ------- > > Instead of finding all or nothing from XCB it becomes components aware. So a > user can just specify which XCB components it needs and compilation doesn't > fail if a not-needed unrelated component is not found. It also allows to have > some components as required and some as optional. > > > Diffs > ----- > > find-modules/FindXCB.cmake 7e7e701 > > Diff: http://git.reviewboard.kde.org/r/112151/diff/ > > > Testing > ------- > > tested in kde-workspace > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
